| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
Same change as done in https://github.com/InfiniTimeOrg/InfiniTime/commit/c3295d6d2a325f9a7418b15b943342635026926e
But for get-base-ref-size job
The variable substitution I introduced are bash features. So they don't work with sh.
Update the size job to use `bash` instead of `sh` as shell
|
| |
|
|
|
|
|
|
|
|
| |
Firmware build works. But the build size job afterwards fails.
The firmware build uses `shell: bash --noprofile --norc -e -o pipefail {0}` as shell.
The size job uses `shell: sh -e {0}`
The variable substitution I introduced are bash features. So they don't work with sh.
Update the size job to use `bash` instead of `sh` as shell
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This fixes CI on #2121.
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
|
| | |
|
| |
|
|
|
| |
Used by script `lv_img_conv.py`, should be provided by docker image, but
until then explicitly install in workflow.
|
| |
|
|
|
| |
InfiniSim has removed the libpng submodule and moved it to a system
dependency.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
The workflow checks that the buildsize comparison succeeds. The download
artifact step also checks that all of the main workflow succeeds. This
isn't necessary, and causes the comment not to be created when the
simulator build fails. This change disabled the success conclusion
requirement.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous version failed, because it looked for the check from the
branch in the fork, but looked for it in the main repo. Now uses the sha
to get the commit on which checks were run.
Previous description
This works by uploading the data from the main workflow with low
permissions as an artifact, then downloading the data in a workflow with
higher permissions to post the comment.
Third party actions are fixed at a commit, in case they get compromised.
Also set the build-firmware VM to ubuntu-22.04, which was missed when
updating workflow deps earlier.
|
| |
|
|
| |
This reverts commit 012c3d25f313148734b4720e376ec24ff6089453.
|
| |
|
|
|
|
|
|
|
|
|
| |
This works by uploading the data from the main workflow with low
permissions as an artifact, then downloading the data in a workflow with
higher permissions to post the comment.
Third party actions are fixed at a commit, in case they get compromised.
Also set the build-firmware VM to ubuntu-22.04, which was missed when
updating workflow deps earlier.
|
| |
|
|
|
|
|
|
| |
The github.event.pull_request.base.sha in the workflow doesn't get
updated when there are new commits in the base branch. Instead always
checkout the branch to check the sha manually and cache only the build.
The ownership fix seems to still be necessary
|
| |
|
|
| |
contact links.
|
| |
|
| |
When people suggest a solution to a generic issue they encounter, they have to open a feature request, which is not optimal. Submitting an issue through this new form will require writing about the issue that led to the idea, which will make it easier to discuss different solutions.
|
| |
|
|
|
|
|
|
|
| |
* Update workflow dependencies
ubuntu-latest vm has been updated from 20.04 to 22.04.
To avoid sudden issues, use 22.04 explicitly.
CMake doesn't need to be updated on 22.04, but ninja must be installed separately in the simulator workflow.
actions/checkout@v2 uses deprecated Node.js 12.
Update to v3 which uses 16
|
| | |
|
| |
|
|
|
|
|
|
| |
Due to a security concern, comments can only be created in the context
of branches in the repo. PRs from forks can't get the comment.
https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#restrictions-on-repository-forks
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add .github/workflows/getSize.sh to extract sizes of sections from the
objfile
build-firmware uses getSize.sh to output the section sizes.
get-base-ref-size job added, which builds the base branch of the PR and
outputs the section sizes. Caches are used to avoid unnecessary builds
when the base branch hasn't been updated.
leave-build-size-comment job added, which creates or updates a comment
on the PR with the build size information from other jobs.
|
| |
|
|
| |
The workaround is no longer necessary
|
| |
|
|
|
| |
Also add configuration options only available in 13 and 14.
Fixes warning about -fstack-usage in clang-tidy check.
|
| | |
|
| |
|
|
| |
build artifacts.
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| |\| |
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
| |
Also fix issue where workflow fails on pull requests when the
user who made the pull request doesn't have the secrets set.
Also allow other workflows to be triggered manually.
Also don't trigger any workflows on pull requests to master, as
there shouldn't be any pull requests against master.
|
| |\ |
|
| | | |
|
| |/
|
|
| |
allow manually starting the workflow.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Uses either the DOCKER_HUB_USERNAME secret or just infinitime as
the username for pushing to and pulling from Docker Hub.
|
| |
|
|
| |
Instead of just checking if it's not pull_request
|
| |
|
|
|
| |
This is so that pull requests that modify the docker image but
don't have the DOCKER_HUB_USERNAME secret set won't fail.
|
| | |
|
| | |
|
| | |
|
| | |
|