From 871a673a4656c438fc12d4c0ad61d2eacc3ca340 Mon Sep 17 00:00:00 2001 From: Jean-François Milants Date: Thu, 2 Dec 2021 21:02:21 +0100 Subject: Tentative : fix issue template that redirect to a blank page. --- .github/ISSUE_TEMPLATE/bug-report.yaml | 1 + .github/ISSUE_TEMPLATE/feature-request.yaml | 1 + 2 files changed, 2 insertions(+) (limited to '.github') diff --git a/.github/ISSUE_TEMPLATE/bug-report.yaml b/.github/ISSUE_TEMPLATE/bug-report.yaml index f0fb076e..6e9f6606 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yaml +++ b/.github/ISSUE_TEMPLATE/bug-report.yaml @@ -9,6 +9,7 @@ body: *Please, before opening a bug report, check if similar issues already exist. In that case, use those issues to provide your feedback instead.* - type: checkboxes attributes: + label: Verification options: - label: I searched for similar bug reports and found none was relevant. required: true diff --git a/.github/ISSUE_TEMPLATE/feature-request.yaml b/.github/ISSUE_TEMPLATE/feature-request.yaml index 26e4fa0f..a35bbfed 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.yaml +++ b/.github/ISSUE_TEMPLATE/feature-request.yaml @@ -9,6 +9,7 @@ body: *Please, before opening a feature request, check if similar issues already exist. In that case, use those issues to provide your feedback instead.* - type: checkboxes attributes: + label: Verification options: - label: I searched for similar feature request and found none was relevant. required: true -- cgit v1.2.3-70-g09d2 From 51d2888b52cb5d8563426954ac4b06679314cee5 Mon Sep 17 00:00:00 2001 From: Jackson Date: Mon, 29 Nov 2021 12:54:30 -0500 Subject: Switch CI/CD to build using ninja vs. make By switching the CI/CD workflow to use CMake's `ninja` backend, the build time goes down considerably (~4.5 minutes to ~2) compared to GNU Make --- .github/workflows/main.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to '.github') diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3b753a37..ac0611cb 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -113,7 +113,7 @@ jobs: run: | mkdir -p build cd build - cmake -DARM_NONE_EABI_TOOLCHAIN_PATH=${{ runner.temp }}/arm-none-eabi -DNRF5_SDK_PATH=${{ runner.temp }}/nrf5_sdk -DUSE_OPENOCD=1 -DBUILD_DFU=1 ../ + cmake -G Ninja -DARM_NONE_EABI_TOOLCHAIN_PATH=${{ runner.temp }}/arm-none-eabi -DNRF5_SDK_PATH=${{ runner.temp }}/nrf5_sdk -DUSE_OPENOCD=1 -DBUILD_DFU=1 ../ ######################################################################################### # Make and Upload DFU Package @@ -126,7 +126,7 @@ jobs: - name: Make pinetime-mcuboot-app run: | cd build - make pinetime-mcuboot-app + ninja pinetime-mcuboot-app - name: Unzip DFU package run: | @@ -145,7 +145,7 @@ jobs: - name: Make pinetime-app run: | cd build - make pinetime-app + ninja pinetime-app - name: Upload standalone firmware uses: actions/upload-artifact@v2 @@ -159,7 +159,7 @@ jobs: - name: Make pinetime-recovery run: | cd build - make pinetime-recovery + ninja pinetime-recovery ######################################################################################### # Finish -- cgit v1.2.3-70-g09d2 From baa5954724a91b81e35812ffd1939438689f3446 Mon Sep 17 00:00:00 2001 From: Jackson Date: Tue, 7 Dec 2021 15:38:53 -0500 Subject: Use CMake universal build command Rather than using generator-specific build commands (ex. `make` or `ninja`), the CI build now uses `cmake --build` for a more modern, best practices approach. --- .github/workflows/main.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to '.github') diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ac0611cb..58a63931 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -125,8 +125,7 @@ jobs: - name: Make pinetime-mcuboot-app run: | - cd build - ninja pinetime-mcuboot-app + cmake --build build --target pinetime-mcuboot-app - name: Unzip DFU package run: | @@ -144,8 +143,7 @@ jobs: - name: Make pinetime-app run: | - cd build - ninja pinetime-app + cmake --build build --target pinetime-app - name: Upload standalone firmware uses: actions/upload-artifact@v2 @@ -158,8 +156,7 @@ jobs: - name: Make pinetime-recovery run: | - cd build - ninja pinetime-recovery + cmake --build build --target pinetime-recovery ######################################################################################### # Finish -- cgit v1.2.3-70-g09d2