From f28aca75419ebaae55b34b688f4d3b9d2f913246 Mon Sep 17 00:00:00 2001
From: codingjourney <coding@journey.sk>
Date: Wed, 23 Oct 2024 23:29:00 +0200
Subject: minor fixes:

* more consistent function names
* lapCapacity as constexpr
* LastLap returns std::optional
* simplified handling of TickType_t values
* removed unused methods
* minor fix in lap rendering
---
 src/components/stopwatch/StopWatchController.cpp | 43 ++++++------------------
 1 file changed, 11 insertions(+), 32 deletions(-)

(limited to 'src/components/stopwatch/StopWatchController.cpp')

diff --git a/src/components/stopwatch/StopWatchController.cpp b/src/components/stopwatch/StopWatchController.cpp
index 200919f4..f9709e6b 100644
--- a/src/components/stopwatch/StopWatchController.cpp
+++ b/src/components/stopwatch/StopWatchController.cpp
@@ -2,20 +2,6 @@
 
 using namespace Pinetime::Controllers;
 
-namespace {
-  TickType_t CalculateDelta(const TickType_t startTime, const TickType_t currentTime) {
-    TickType_t delta = 0;
-    // Take care of overflow
-    if (startTime > currentTime) {
-      delta = 0xffffffff - startTime;
-      delta += (currentTime + 1);
-    } else {
-      delta = currentTime - startTime;
-    }
-    return delta;
-  }
-}
-
 StopWatchController::StopWatchController() {
   Clear();
 }
@@ -29,14 +15,14 @@ void StopWatchController::Start() {
 
 void StopWatchController::Pause() {
   currentState = StopWatchStates::Paused;
-  timeElapsedPreviously += CalculateDelta(startTime, xTaskGetTickCount());
+  timeElapsedPreviously += xTaskGetTickCount() - startTime;
 }
 
 void StopWatchController::Clear() {
   currentState = StopWatchStates::Cleared;
   timeElapsedPreviously = 0;
 
-  for (int i = 0; i < LAP_CAPACITY; i++) {
+  for (int i = 0; i < lapCapacity; i++) {
     laps[i].count = 0;
     laps[i].time = 0;
   }
@@ -51,14 +37,7 @@ void StopWatchController::PushLap() {
   laps[lapHead].time = lapEnd;
   laps[lapHead].count = lapCount + 1;
   lapCount += 1;
-  lapHead = lapCount % LAP_CAPACITY;
-}
-
-int StopWatchController::GetLapNum() {
-  if (lapCount < LAP_CAPACITY)
-    return lapCount;
-  else
-    return LAP_CAPACITY;
+  lapHead = lapCount % lapCapacity;
 }
 
 int StopWatchController::GetLapCount() {
@@ -66,17 +45,17 @@ int StopWatchController::GetLapCount() {
 }
 
 int Wrap(int index) {
-  return ((index % LAP_CAPACITY) + LAP_CAPACITY) % LAP_CAPACITY;
+  return ((index % lapCapacity) + lapCapacity) % lapCapacity;
 }
 
-LapInfo* StopWatchController::LastLap(int lap) {
-  if (lap >= LAP_CAPACITY || lap > lapCount || lapCount == 0) {
-    // Return "empty" LapInfo_t
-    return &emptyLapInfo;
+std::optional<LapInfo> StopWatchController::LastLap(int lap) {
+  if (lap >= lapCapacity || lap >= lapCount) {
+    return {};
   }
   // Index backwards
-  int index = Wrap(lapHead - lap);
-  return &laps[index];
+  int mostRecentLap = lapHead - 1;
+  int index = Wrap(mostRecentLap - lap);
+  return laps[index];
 }
 
 // Data / State acess
@@ -85,7 +64,7 @@ TickType_t StopWatchController::GetElapsedTime() {
   if (!IsRunning()) {
     return timeElapsedPreviously;
   }
-  return timeElapsedPreviously + CalculateDelta(startTime, xTaskGetTickCount());
+  return timeElapsedPreviously + (xTaskGetTickCount() - startTime);
 }
 
 bool StopWatchController::IsRunning() {
-- 
cgit v1.2.3-70-g09d2