From 52baa265feecbb83dcf0419cfaddcd75dde9ccba Mon Sep 17 00:00:00 2001 From: FintasticMan Date: Tue, 10 Dec 2024 00:11:13 +0100 Subject: weather: Fix incorrect rounding for negative temperatures --- src/utility/Math.h | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) (limited to 'src/utility/Math.h') diff --git a/src/utility/Math.h b/src/utility/Math.h index e8d190c7..314e4e37 100644 --- a/src/utility/Math.h +++ b/src/utility/Math.h @@ -1,10 +1,33 @@ #pragma once #include +#include namespace Pinetime { namespace Utility { // returns the arcsin of `arg`. asin(-32767) = -90, asin(32767) = 90 int16_t Asin(int16_t arg); + + // Round half away from zero integer division + // If T signed, divisor cannot be std::numeric_limits::min() + // Adapted from https://github.com/lucianpls/rounding_integer_division + // Under the MIT license + template + constexpr T RoundedDiv(T dividend, T divisor) { + bool neg = divisor < 0; + if (neg) { + // overflows if divisor is minimum value for T + divisor = -divisor; + } + + T m = dividend % divisor; + T h = divisor / 2 + divisor % 2; + T res = (dividend / divisor) + (!(dividend < 0) & (m >= h)) - ((dividend < 0) & ((m + h) <= 0)); + + if (neg) { + res = -res; + } + return res; + } } } -- cgit v1.2.3-70-g09d2