From 53b85e8fab165b45b71f61014642190443f1b487 Mon Sep 17 00:00:00 2001 From: AKP Date: Mon, 10 Feb 2025 22:13:37 +0000 Subject: Do not index feed items at addition time This is now handled gracefully in the processor logic. --- CHANGELOG.md | 1 + walrss/internal/http/new.go | 6 ------ walrss/internal/rss/setup.go | 23 ----------------------- 3 files changed, 1 insertion(+), 29 deletions(-) delete mode 100644 walrss/internal/rss/setup.go diff --git a/CHANGELOG.md b/CHANGELOG.md index 55e0d1f..565b90b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## Unreleased ### Changed * When no feed items are stored in the database for a particular feed, fall back to using the old time-based detection method +* Do not index feed items at addition time ## 0.4.2 - 2025-02-09 ### Fixed diff --git a/walrss/internal/http/new.go b/walrss/internal/http/new.go index 89c02dc..7b57815 100644 --- a/walrss/internal/http/new.go +++ b/walrss/internal/http/new.go @@ -1,10 +1,8 @@ package http import ( - "fmt" "github.com/codemicro/walrss/walrss/internal/core" "github.com/codemicro/walrss/walrss/internal/http/views" - "github.com/codemicro/walrss/walrss/internal/rss" "github.com/codemicro/walrss/walrss/internal/urls" "github.com/gofiber/fiber/v2" ) @@ -30,10 +28,6 @@ func (s *Server) newFeedItem(ctx *fiber.Ctx) error { return err } - if err := rss.LoadInitialItems(s.state, feed); err != nil { - return fmt.Errorf("load initial items for new feed %s: %w", feed.ID, err) - } - return ctx.SendString(views.RenderFeedRow(feed.ID, feed.Name, feed.URL)) } diff --git a/walrss/internal/rss/setup.go b/walrss/internal/rss/setup.go deleted file mode 100644 index 27f62ad..0000000 --- a/walrss/internal/rss/setup.go +++ /dev/null @@ -1,23 +0,0 @@ -package rss - -import ( - "fmt" - "github.com/codemicro/walrss/walrss/internal/core" - "github.com/codemicro/walrss/walrss/internal/db" - "github.com/codemicro/walrss/walrss/internal/state" -) - -func LoadInitialItems(st *state.State, feed *db.Feed) error { - content, err := getFeedContent(st, feed) - if err != nil { - return core.AsUserError(400, fmt.Errorf("get feed content: %w", err)) - } - - var fis []*db.FeedItem - - for _, item := range content.Items { - fis = append(fis, &db.FeedItem{FeedID: feed.ID, ItemID: item.GUID}) - } - - return core.NewFeedItems(st, fis) -} -- cgit v1.2.3-70-g09d2