From 099519e872848c9f67c59e5c0db53aa66c213137 Mon Sep 17 00:00:00 2001 From: Krakenied Date: Sat, 10 Dec 2022 20:21:33 +0100 Subject: Optimize debug logging Fixes https://github.com/LMBishop/Quests/issues/452 --- .../bukkit/tasktype/BukkitTaskTypeManager.java | 32 ++++++++++++++-------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/BukkitTaskTypeManager.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/BukkitTaskTypeManager.java index 3ad57e90..ec41039d 100644 --- a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/BukkitTaskTypeManager.java +++ b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/BukkitTaskTypeManager.java @@ -39,24 +39,34 @@ public class BukkitTaskTypeManager extends TaskTypeManager { } public void sendDebug(@NotNull String message, @NotNull String taskType, @NotNull String questId, @NotNull String taskId, @NotNull UUID associatedPlayer) { + String chatHeader = null; for (QPlayer qPlayer : plugin.getPlayerManager().getQPlayers()) { QPlayerPreferences.DebugType debugType = qPlayer.getPlayerPreferences().getDebug(questId); + if (debugType == null) { + continue; + } + Player player = Bukkit.getPlayer(qPlayer.getPlayerUUID()); - Player otherPlayer = Bukkit.getPlayer(associatedPlayer); - String associatedName = otherPlayer == null ? associatedPlayer.toString() : otherPlayer.getName(); + if (player == null) { + continue; + } - String chatHeader = ChatColor.GRAY + "[" + associatedName + " - " + questId + "/" + taskId + " - type '" + taskType + "']"; - if (player != null && debugType != null) { - switch (debugType) { - case ALL -> { + if (chatHeader == null) { + Player otherPlayer = Bukkit.getPlayer(associatedPlayer); + String associatedName = otherPlayer != null ? otherPlayer.getName() : associatedPlayer.toString(); + chatHeader = ChatColor.GRAY + "[" + associatedName + " - " + questId + "/" + taskId + " - type '" + taskType + "']"; + } + + switch (debugType) { + case ALL -> { + player.sendMessage(chatHeader); + player.sendMessage(message); + } + case SELF -> { + if (player.getUniqueId().equals(associatedPlayer)) { player.sendMessage(chatHeader); player.sendMessage(message); } - case SELF -> { - if (player.getUniqueId().equals(associatedPlayer)) { - player.sendMessage(chatHeader); - player.sendMessage(message); } - } } } } -- cgit v1.2.3-70-g09d2