From 1b84913bed2c6ef88a5336fa18b5ec8d23af7d33 Mon Sep 17 00:00:00 2001 From: Krakenied Date: Fri, 29 Mar 2024 09:25:52 +0100 Subject: Fixes almost unreproducible rewards dupe on completion Closes https://github.com/LMBishop/Quests/issues/543 --- .../quests/common/player/questprogressfile/TaskProgress.java | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'common/src/main/java/com/leonardobishop') diff --git a/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java b/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java index c0d9c786..a78a4d25 100644 --- a/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java +++ b/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java @@ -56,6 +56,12 @@ public class TaskProgress { } public void setCompleted(boolean complete) { + // do not queue completion for already completed quests + // https://github.com/LMBishop/Quests/issues/543 + if (this.completed == complete) { + return; + } + this.completed = complete; this.modified = true; -- cgit v1.2.3-70-g09d2