From e4181063076628e8819268478a5359b6b4999176 Mon Sep 17 00:00:00 2001 From: Krakenied Date: Wed, 13 Mar 2024 10:53:44 +0100 Subject: Remove unnecessary HashMap#containsKey call from hot path Related to https://github.com/LMBishop/Quests/issues/629 --- .../quests/common/player/questprogressfile/QuestProgressFile.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'common/src') diff --git a/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/QuestProgressFile.java b/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/QuestProgressFile.java index 222a925e..b1f048b7 100644 --- a/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/QuestProgressFile.java +++ b/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/QuestProgressFile.java @@ -222,7 +222,8 @@ public class QuestProgressFile { * @return true if player has the quest started */ public boolean hasQuestStarted(Quest quest) { - return questProgress.containsKey(quest.getId()) && questProgress.get(quest.getId()).isStarted(); + QuestProgress qProgress = questProgress.get(quest.getId()); + return qProgress != null && qProgress.isStarted(); } /** -- cgit v1.2.3-70-g09d2