aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKrakenied <Krakenied1@gmail.com>2024-03-29 09:25:52 +0100
committerLeonardo Bishop <13875753+LMBishop@users.noreply.github.com>2024-04-25 22:05:17 +0100
commit1b84913bed2c6ef88a5336fa18b5ec8d23af7d33 (patch)
tree2b5967ef9a465dca5487d990fc16a53c9d42e736
parent2520b644fcc56bf19071113e71e4077390dd5f11 (diff)
Fixes almost unreproducible rewards dupe on completion
Closes https://github.com/LMBishop/Quests/issues/543
-rw-r--r--common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java6
1 files changed, 6 insertions, 0 deletions
diff --git a/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java b/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java
index c0d9c786..a78a4d25 100644
--- a/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java
+++ b/common/src/main/java/com/leonardobishop/quests/common/player/questprogressfile/TaskProgress.java
@@ -56,6 +56,12 @@ public class TaskProgress {
}
public void setCompleted(boolean complete) {
+ // do not queue completion for already completed quests
+ // https://github.com/LMBishop/Quests/issues/543
+ if (this.completed == complete) {
+ return;
+ }
+
this.completed = complete;
this.modified = true;